From 27824ec5860dd0d954c13ce3e13ea02eccfc4e6c Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Wed, 26 Jun 2019 06:54:51 +0200 Subject: [PATCH 1/5] Stretched link updates (#28958) - Remove IE10 background hack - Ability to change the pseudo element - Ability to change the z-index - Remove pointer events, just inherit this --- scss/_variables.scss | 3 +++ scss/helpers/_stretched-link.scss | 8 ++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index 9eea07d39..29961e4dd 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -161,6 +161,9 @@ $link-hover-decoration: underline !default; // Darken percentage for links with `.text-*` class (e.g. `.text-success`) $emphasized-link-hover-darken-percentage: 15% !default; +$stretched-link-pseudo-element: after !default; +$stretched-link-z-index: 1 !default; + // Paragraphs // // Style p element. diff --git a/scss/helpers/_stretched-link.scss b/scss/helpers/_stretched-link.scss index fb5066bf5..71a1c755a 100644 --- a/scss/helpers/_stretched-link.scss +++ b/scss/helpers/_stretched-link.scss @@ -3,17 +3,13 @@ // .stretched-link { - &::after { + &::#{$stretched-link-pseudo-element} { position: absolute; top: 0; right: 0; bottom: 0; left: 0; - z-index: 1; - // Just in case `pointer-events: none` is set on a parent - pointer-events: auto; + z-index: $stretched-link-z-index; content: ""; - // IE10 bugfix, see https://stackoverflow.com/questions/16947967/ie10-hover-pseudo-class-doesnt-work-without-background-color - background-color: rgba(0, 0, 0, 0); } } From 65f21bbef171282fae63dad078fdca7d37b0ab26 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Wed, 26 Jun 2019 12:18:59 +0200 Subject: [PATCH 2/5] Fix pre color (#28966) --- scss/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index 29961e4dd..7b28d94dd 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -1100,5 +1100,5 @@ $kbd-font-size: $code-font-size !default; $kbd-color: $white !default; $kbd-bg: $gray-900 !default; -$pre-color: $gray-900 !default; +$pre-color: null !default; $pre-scrollable-max-height: 340px !default; From 4b3d2635f34a36742f6f3ab0f969a80b0c21a0ef Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Wed, 26 Jun 2019 15:11:37 +0200 Subject: [PATCH 3/5] Remove redundant radius properties (#28956) --- scss/_list-group.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scss/_list-group.scss b/scss/_list-group.scss index d857bf8fd..3f20758da 100644 --- a/scss/_list-group.scss +++ b/scss/_list-group.scss @@ -97,12 +97,12 @@ .list-group-item { &:first-child { - @include border-left-radius($list-group-border-radius); + @include border-bottom-left-radius($list-group-border-radius); @include border-top-right-radius(0); } &:last-child { - @include border-right-radius($list-group-border-radius); + @include border-top-right-radius($list-group-border-radius); @include border-bottom-left-radius(0); } From f5f09d8b0b97ffb0c5c0b01ad503ccfe0cf7f506 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Tue, 2 Jul 2019 08:08:12 +0200 Subject: [PATCH 4/5] Remove redundant border radius on pagination (#28980) Pagination used to have box shadow back in the days which required this property, but nowadays it's redundant. (see https://github.com/twbs/bootstrap/blame/0cd186183c5e18f0517d6037d53f29c56adbac72/less/pagination.less#L17) --- scss/_pagination.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/scss/_pagination.scss b/scss/_pagination.scss index 953a35a7f..27e7bb805 100644 --- a/scss/_pagination.scss +++ b/scss/_pagination.scss @@ -1,7 +1,6 @@ .pagination { display: flex; @include list-unstyled(); - @include border-radius(); } .page-link { From 08bddb8743cb5328c9211e93898aff9ecba88c80 Mon Sep 17 00:00:00 2001 From: Bardi Harborow Date: Wed, 3 Jul 2019 04:17:42 +1000 Subject: [PATCH 5/5] Add ARIA search landmark to documentation. (#28983) --- site/layouts/partials/docs-sidebar.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/layouts/partials/docs-sidebar.html b/site/layouts/partials/docs-sidebar.html index b87dcde84..3f6ec67e7 100644 --- a/site/layouts/partials/docs-sidebar.html +++ b/site/layouts/partials/docs-sidebar.html @@ -1,4 +1,4 @@ -