From 33df950b276a31d044dfacbbd19145e11e6e4afe Mon Sep 17 00:00:00 2001
From: patrickhlauke <redux@splintered.co.uk>
Date: Tue, 18 Jun 2019 20:19:53 +0100
Subject: [PATCH] Remove dropdown-in-tabs related code

- there's no ARIA pattern that would allow dropdowns in tablists; it cannot be expressed accessibly to AT users. it also has serious usability drawbacks. we're already saying in the docs it should not be
used ... this goes a step further and removes the handling for it
---
 js/src/tab.js | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/js/src/tab.js b/js/src/tab.js
index dc0acec2a..bde07818c 100644
--- a/js/src/tab.js
+++ b/js/src/tab.js
@@ -45,7 +45,6 @@ const Event = {
 }
 
 const ClassName = {
-  DROPDOWN_MENU: 'dropdown-menu',
   ACTIVE: 'active',
   DISABLED: 'disabled',
   FADE: 'fade',
@@ -53,14 +52,11 @@ const ClassName = {
 }
 
 const Selector = {
-  DROPDOWN: '.dropdown',
   NAV_LIST_GROUP: '.nav, .list-group',
   ACTIVE: '.active',
   ACTIVE_UL: ':scope > li > .active',
   DATA_TOGGLE: '[data-toggle="tab"], [data-toggle="pill"], [data-toggle="list"]',
-  TABLIST: '[role="tablist"]',
-  DROPDOWN_TOGGLE: '.dropdown-toggle',
-  DROPDOWN_ACTIVE_CHILD: ':scope > .dropdown-menu .active'
+  TABLIST: '[role="tablist"]'
 }
 
 /**
@@ -182,12 +178,6 @@ class Tab {
     if (active) {
       active.classList.remove(ClassName.ACTIVE)
 
-      const dropdownChild = SelectorEngine.findOne(Selector.DROPDOWN_ACTIVE_CHILD, active.parentNode)
-
-      if (dropdownChild) {
-        dropdownChild.classList.remove(ClassName.ACTIVE)
-      }
-
       if (active.getAttribute('role') === 'tab') {
         active.setAttribute('aria-selected', false)
         active.setAttribute('tabindex', '-1')
@@ -206,17 +196,6 @@ class Tab {
       element.classList.add(ClassName.SHOW)
     }
 
-    if (element.parentNode && element.parentNode.classList.contains(ClassName.DROPDOWN_MENU)) {
-      const dropdownElement = SelectorEngine.closest(element, Selector.DROPDOWN)
-
-      if (dropdownElement) {
-        makeArray(SelectorEngine.find(Selector.DROPDOWN_TOGGLE))
-          .forEach(dropdown => dropdown.classList.add(ClassName.ACTIVE))
-      }
-
-      element.setAttribute('aria-expanded', true)
-    }
-
     if (callback) {
       callback()
     }