From 34f38ce51602eb43c666e92b303d27792818d509 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 5 Jan 2021 21:59:17 +0000 Subject: [PATCH] Update js unit and visual test accordingly - replace links with buttons - make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate - remove tests involving dropdown tabs, as they're discouraged (though still silently supported) --- js/tests/unit/tab.spec.js | 143 +++++++++++++++++++------------------- js/tests/visual/tab.html | 73 ++++++------------- 2 files changed, 92 insertions(+), 124 deletions(-) diff --git a/js/tests/unit/tab.spec.js b/js/tests/unit/tab.spec.js index 67a85b2e4..f9dd1e352 100644 --- a/js/tests/unit/tab.spec.js +++ b/js/tests/unit/tab.spec.js @@ -21,15 +21,39 @@ describe('Tab', () => { }) describe('show', () => { - it('should activate element by tab id', done => { + it('should activate element by tab id (using buttons, the preferred semantic way)', done => { fixtureEl.innerHTML = [ - '