rev/bootstrap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tweak

Browse source 
Stick with the naive `tabs[index].click()` as it works correctly, and trying to trigger just `show()` of a tab instance resulted in weird side effects...

Tighten the outer `makeArrary`/`forEach` loop (assuming when there's an empty array the forEach just bails, so no need to check the length?)
This commit is contained in:
patrickhlauke 2019-06-19 12:47:13 +01:00 • committed by Johann-S
parent 7c79b8a80f
commit 3c8170044a
1 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
js/src/tab.js
View file

@ -261,7 +261,7 @@ class Tab {
}
tabs[index].focus()
tabs[index].click() // WIP naive way of doing this? any better way? calling _activate or something?
tabs[index].click()
}
static _getInstance(element) {
@ -276,14 +276,8 @@ class Tab {
*/
EventHandler.on(window, Event.LOAD_DATA_API, () => {
const tablists = makeArray(SelectorEngine.find(Selector.TABLIST))
if (!tablists.length) {
return
}
// iterate over all found sets of tab lists
for (let i = 0; i < tablists.length; i++) {
const tabs = makeArray(SelectorEngine.find(Selector.DATA_TOGGLE, tablists[i]))
makeArray(SelectorEngine.find(Selector.TABLIST)).forEach(tablist => {
const tabs = makeArray(SelectorEngine.find(Selector.DATA_TOGGLE, tablist))
let selectedTabFound = false
// iterate over each tab in the tablist, make sure they have correct tabindex/aria-selected
@ -302,7 +296,7 @@ EventHandler.on(window, Event.LOAD_DATA_API, () => {
tabs[0].setAttribute('tabindex', '0')
tabs[0].setAttribute('aria-selected', 'true')
}
}
})
})
EventHandler.on(document, Event.KEYDOWN_DATA_API, Selector.DATA_TOGGLE, Tab._dataApiKeydownHandler)
EventHandler.on(document, Event.CLICK_DATA_API, Selector.DATA_TOGGLE, function (event) {