Remove a few null strict checks
This commit is contained in:
parent
93ab072027
commit
d230c4ae3b
4 changed files with 10 additions and 9 deletions
|
|
@ -55,7 +55,7 @@ class Alert extends BaseComponent {
|
|||
const rootElement = element ? this._getRootElement(element) : this._element
|
||||
const customEvent = this._triggerCloseEvent(rootElement)
|
||||
|
||||
if (customEvent === null || customEvent.defaultPrevented) {
|
||||
if (!customEvent || customEvent.defaultPrevented) {
|
||||
return
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -84,7 +84,7 @@ class Collapse extends BaseComponent {
|
|||
const filterElement = SelectorEngine.find(selector)
|
||||
.filter(foundElem => foundElem === element)
|
||||
|
||||
if (selector !== null && filterElement.length) {
|
||||
if (selector && filterElement.length) {
|
||||
this._selector = selector
|
||||
this._triggerArray.push(elem)
|
||||
}
|
||||
|
|
@ -384,7 +384,7 @@ EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_DATA_TOGGLE, function (
|
|||
let config
|
||||
if (data) {
|
||||
// update parent attribute
|
||||
if (data._parent === null && typeof triggerData.parent === 'string') {
|
||||
if (data._parent && typeof triggerData.parent === 'string') {
|
||||
data._config.parent = triggerData.parent
|
||||
data._parent = data._getParent()
|
||||
}
|
||||
|
|
|
|||
|
|
@ -91,7 +91,7 @@ class Tab extends BaseComponent {
|
|||
relatedTarget: previous
|
||||
})
|
||||
|
||||
if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) {
|
||||
if (showEvent.defaultPrevented || (hideEvent && hideEvent.defaultPrevented)) {
|
||||
return
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -248,9 +248,9 @@ class Tooltip extends BaseComponent {
|
|||
if (this.isWithContent() && this._isEnabled) {
|
||||
const showEvent = EventHandler.trigger(this._element, this.constructor.Event.SHOW)
|
||||
const shadowRoot = findShadowRoot(this._element)
|
||||
const isInTheDom = shadowRoot === null ?
|
||||
this._element.ownerDocument.documentElement.contains(this._element) :
|
||||
shadowRoot.contains(this._element)
|
||||
const isInTheDom = shadowRoot ?
|
||||
shadowRoot.contains(this._element) :
|
||||
this._element.ownerDocument.documentElement.contains(this._element)
|
||||
|
||||
if (showEvent.defaultPrevented || !isInTheDom) {
|
||||
return
|
||||
|
|
@ -406,7 +406,7 @@ class Tooltip extends BaseComponent {
|
|||
}
|
||||
|
||||
setElementContent(element, content) {
|
||||
if (element === null) {
|
||||
if (!element) {
|
||||
return
|
||||
}
|
||||
|
||||
|
|
@ -734,7 +734,8 @@ class Tooltip extends BaseComponent {
|
|||
_cleanTipClass() {
|
||||
const tip = this.getTipElement()
|
||||
const tabClass = tip.getAttribute('class').match(BSCLS_PREFIX_REGEX)
|
||||
if (tabClass !== null && tabClass.length > 0) {
|
||||
|
||||
if (tabClass && tabClass.length > 0) {
|
||||
tabClass.map(token => token.trim())
|
||||
.forEach(tClass => tip.classList.remove(tClass))
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue