From ec2172dfdbf6a7111934200049660905726ce6ca Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 16 Dec 2020 11:24:14 +0200 Subject: [PATCH] Revert "WIP" --- js/src/carousel.js | 10 ++++------ js/src/dropdown.js | 14 ++++++-------- js/src/modal.js | 6 ++---- js/src/tooltip.js | 5 ++--- 4 files changed, 14 insertions(+), 21 deletions(-) diff --git a/js/src/carousel.js b/js/src/carousel.js index 6199023f6..d38eb481d 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -96,8 +96,6 @@ const SELECTOR_DATA_RIDE = '[data-bs-ride="carousel"]' const POINTER_TYPE_TOUCH = 'touch' const POINTER_TYPE_PEN = 'pen' -const IS_RTL = isRTL() - /** * ------------------------------------------------------------------------ * Class Definition @@ -253,7 +251,7 @@ class Carousel extends BaseComponent { // swipe left if (direction > 0) { - if (IS_RTL) { + if (isRTL()) { this.next() } else { this.prev() @@ -262,7 +260,7 @@ class Carousel extends BaseComponent { // swipe right if (direction < 0) { - if (IS_RTL) { + if (isRTL()) { this.prev() } else { this.next() @@ -350,14 +348,14 @@ class Carousel extends BaseComponent { if (event.key === ARROW_LEFT_KEY) { event.preventDefault() - if (IS_RTL) { + if (isRTL()) { this.next() } else { this.prev() } } else if (event.key === ARROW_RIGHT_KEY) { event.preventDefault() - if (IS_RTL) { + if (isRTL()) { this.prev() } else { this.next() diff --git a/js/src/dropdown.js b/js/src/dropdown.js index 8a6e75bfa..ba588a606 100644 --- a/js/src/dropdown.js +++ b/js/src/dropdown.js @@ -64,14 +64,12 @@ const SELECTOR_MENU = '.dropdown-menu' const SELECTOR_NAVBAR_NAV = '.navbar-nav' const SELECTOR_VISIBLE_ITEMS = '.dropdown-menu .dropdown-item:not(.disabled):not(:disabled)' -const IS_RTL = isRTL() - -const PLACEMENT_TOP = IS_RTL ? 'top-end' : 'top-start' -const PLACEMENT_TOPEND = IS_RTL ? 'top-start' : 'top-end' -const PLACEMENT_BOTTOM = IS_RTL ? 'bottom-end' : 'bottom-start' -const PLACEMENT_BOTTOMEND = IS_RTL ? 'bottom-start' : 'bottom-end' -const PLACEMENT_RIGHT = IS_RTL ? 'left-start' : 'right-start' -const PLACEMENT_LEFT = IS_RTL ? 'right-start' : 'left-start' +const PLACEMENT_TOP = isRTL() ? 'top-end' : 'top-start' +const PLACEMENT_TOPEND = isRTL() ? 'top-start' : 'top-end' +const PLACEMENT_BOTTOM = isRTL() ? 'bottom-end' : 'bottom-start' +const PLACEMENT_BOTTOMEND = isRTL() ? 'bottom-start' : 'bottom-end' +const PLACEMENT_RIGHT = isRTL() ? 'left-start' : 'right-start' +const PLACEMENT_LEFT = isRTL() ? 'right-start' : 'left-start' const Default = { offset: 0, diff --git a/js/src/modal.js b/js/src/modal.js index b20cabc23..b1656803d 100644 --- a/js/src/modal.js +++ b/js/src/modal.js @@ -72,8 +72,6 @@ const SELECTOR_DATA_DISMISS = '[data-bs-dismiss="modal"]' const SELECTOR_FIXED_CONTENT = '.fixed-top, .fixed-bottom, .is-fixed, .sticky-top' const SELECTOR_STICKY_CONTENT = '.sticky-top' -const IS_RTL = isRTL() - /** * ------------------------------------------------------------------------ * Class Definition @@ -435,11 +433,11 @@ class Modal extends BaseComponent { _adjustDialog() { const isModalOverflowing = this._element.scrollHeight > document.documentElement.clientHeight - if ((!this._isBodyOverflowing && isModalOverflowing && !IS_RTL) || (this._isBodyOverflowing && !isModalOverflowing && IS_RTL)) { + if ((!this._isBodyOverflowing && isModalOverflowing && !isRTL()) || (this._isBodyOverflowing && !isModalOverflowing && isRTL())) { this._element.style.paddingLeft = `${this._scrollbarWidth}px` } - if ((this._isBodyOverflowing && !isModalOverflowing && !IS_RTL) || (!this._isBodyOverflowing && isModalOverflowing && IS_RTL)) { + if ((this._isBodyOverflowing && !isModalOverflowing && !isRTL()) || (!this._isBodyOverflowing && isModalOverflowing && isRTL())) { this._element.style.paddingRight = `${this._scrollbarWidth}px` } } diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 634c803ad..77a4dcc3d 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -40,7 +40,6 @@ const EVENT_KEY = `.${DATA_KEY}` const CLASS_PREFIX = 'bs-tooltip' const BSCLS_PREFIX_REGEX = new RegExp(`(^|\\s)${CLASS_PREFIX}\\S+`, 'g') const DISALLOWED_ATTRIBUTES = new Set(['sanitize', 'allowList', 'sanitizeFn']) -const IS_RTL = isRTL() const DefaultType = { animation: 'boolean', @@ -64,9 +63,9 @@ const DefaultType = { const AttachmentMap = { AUTO: 'auto', TOP: 'top', - RIGHT: IS_RTL ? 'left' : 'right', + RIGHT: isRTL() ? 'left' : 'right', BOTTOM: 'bottom', - LEFT: IS_RTL ? 'right' : 'left' + LEFT: isRTL() ? 'right' : 'left' } const Default = {