Commit graph

1738 commits

Author SHA1 Message Date
patrickhlauke
35179a4aee Remove dropdown-in-tabs related unit tests
Since that logic has now been expunged
2019-07-08 14:20:19 +02:00
patrickhlauke
a8cf124b82 Initial code tweaks based on comments 2019-07-08 14:20:19 +02:00
patrickhlauke
a1e7738632 Remove dropdown-in-tabs related code
- there's no ARIA pattern that would allow dropdowns in tablists; it cannot be expressed accessibly to AT users. it also has serious usability drawbacks. we're already saying in the docs it should not be
used ... this goes a step further and removes the handling for it
2019-07-08 14:20:19 +02:00
patrickhlauke
da9f93da1c WIP add initial keyboard handling and initialisation
- initialisation happens very inelegantly - could do with some advice on how to move this to a function (should it be public, private, static?)
- keyboard handling works, but seems to get confused when switching too quickly between tabs sometimes
- activating tabs currently done via click() - there must be a nicer way to do this...how? fire _activate? which parameters to pass?
2019-07-08 14:20:19 +02:00
patrickhlauke
2e5a010901 Add initial tabindex handling for tabs
set `tabindex` as well as `aria-selected` on tabs
2019-07-08 14:20:18 +02:00
Patrick H. Lauke
f2c63ac729 Port new unit test for dropdown from v4 (#28913)
Add unit test from #28912 to v5
2019-06-25 14:57:41 +03:00
Patrick H. Lauke
f0f75379f6 Closing dropdown with ESC correctly sets focus to toggle (#28928)
Just firing the focus event isn't enough ... need to actually call the proper `focus()` method for it to actually do it...
2019-06-19 12:23:41 +03:00
david-lallement
0829decce0 tooltip dispose:removing only own event handler (#28896) 2019-06-13 10:42:54 +02:00
XhmikosR
8a79cf894d event-handler.js: use a plain for loop. (#28853) 2019-06-03 13:08:17 +02:00
Johann-S
d5752a18ab toast should allow prevent default for hide and show events 2019-05-16 13:24:29 +02:00
Johann-S
c805aec770 fix popover arrow by selecting the first element child 2019-05-14 15:28:43 +02:00
Martijn Cuppens
a827934f13 Documentation tweaks (#28679)
* Documentation tweaks

* Remove redundant col-12 classes
2019-05-08 19:58:29 +03:00
XhmikosR
438e01b61c Rename eventHandler and selectorEngine files. 2019-05-08 17:26:37 +03:00
Johann-S
dda31bbee6 improve build plugin script to keep file name 2019-05-08 17:26:37 +03:00
XhmikosR
e7657c8bc0 Remove the unicorn/filename-case rule suppression. 2019-05-08 17:26:37 +03:00
XhmikosR
091aa1e9fd
v5 dist (#28657) 2019-04-18 14:47:52 +03:00
Johann-S
14f53d9baa fix unit tests for chrome mobile 2019-04-15 13:48:27 +02:00
XhmikosR
afc63ec887 Fix xo error: use for...of. 2019-04-10 15:18:57 +03:00
XhmikosR
105687ac4a Update eslint config for the new xo rules. 2019-04-10 15:18:57 +03:00
ysds
f4877dbf03 Remove _close() and marge with _hide() 2019-04-09 13:59:41 +02:00
ysds
91ebb4b3b2 Call hide() after delay time 2019-04-09 13:59:41 +02:00
XhmikosR
efb9a7749f
karma.conf.js: switch to CI === true. (#28588) 2019-04-01 17:26:43 +03:00
Johann-S
1752addadf Reset carousel touch delta x to prevent click transformation in swipe (#28558) 2019-03-27 14:37:04 +02:00
Johann-S
ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
Johann-S
08679ac0b5 Add back support for IE 11 2019-03-18 01:11:05 +02:00
XhmikosR
6aa475c82e
Use one-line imports when possible. (#28467) 2019-03-13 14:55:53 +02:00
XhmikosR
ac67e04ce0 Dist. 2019-03-11 17:59:08 +02:00
Johann-S
2fd50f98a5 build bootstrap in esm 2019-03-11 17:59:08 +02:00
XhmikosR
3ffe3a5d82 collapse.js: minor refactoring. 2019-03-11 17:01:28 +02:00
XhmikosR
1393678f0b Remove obsolete comments. 2019-03-11 17:01:28 +02:00
XhmikosR
dd0239d169 Remove more unused properties. 2019-03-11 17:01:28 +02:00
Johann-S
dce47b5451 scrollspy.js: remove unused properties 2019-03-11 17:01:28 +02:00
XhmikosR
5ac1a12625 Remove assignment from return. 2019-03-11 17:01:28 +02:00
XhmikosR
5bcd6a29cd Disable a few rules for now. 2019-03-11 17:01:28 +02:00
XhmikosR
46c037410b Comply to the new rules. 2019-03-11 17:01:28 +02:00
XhmikosR
44e6abcba5 Switch to eslint-config-xo and eslint-plugin-unicorn. 2019-03-11 17:01:28 +02:00
XhmikosR
19aee321a0
Dist (#28392) 2019-03-01 18:31:34 +02:00
XhmikosR
d5f9107abb
Remove the now unneeded shrink-to-fit directive. (#28314) 2019-02-27 17:47:41 +02:00
XhmikosR
9cbd041f6b
tests: add tests for plugins version. (#28366) 2019-02-27 13:20:25 +02:00
XhmikosR
f7b55da450
dom/manipulator.js: minor simplification. (#28358)
Combine two checks since we return the same value for both.
2019-02-26 13:13:01 +02:00
XhmikosR
7933ee3282 karma.conf.js: minor simplification. 2019-02-26 13:04:04 +02:00
Johann-S
497518db1a remove tests for old jQuery 1.9.x compatibility 2019-02-26 13:04:04 +02:00
Johann-S
8a37045b79 move util in a util folder with the sanitizer 2019-02-26 13:04:04 +02:00
XhmikosR
5ad2121819
Remove DOMContentLoaded. (#28337)
There's no reason for us to wait here.
2019-02-24 15:42:18 +02:00
XhmikosR
423e4a3811 tests/visual/modal.html: fix close button placement. 2019-02-20 22:05:45 +02:00
Johann-S
fee11fd7ae use our selector engine instead of native api 2019-02-20 22:05:45 +02:00
XhmikosR
68e6de42ec Use Util.makeArray(). 2019-02-20 22:05:45 +02:00
Johann-S
e58b47cf74 improve event handler 2019-02-20 22:05:45 +02:00
XhmikosR
30861cbc6d Simplify checks. 2019-02-20 22:05:45 +02:00
XhmikosR
4b7c058a25 Remove unneeded ESLint suppression. 2019-02-20 22:05:45 +02:00