From 66e4d1f40eaf8d955baab6b5566744cc9e0ae4fb Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Thu, 17 Dec 2020 15:39:00 +0200 Subject: [PATCH 1/2] Add GitHub sha in BrowserStack build ID. --- .github/workflows/browserstack.yml | 1 + js/tests/karma.conf.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/browserstack.yml b/.github/workflows/browserstack.yml index 00831721d..16b2c75d6 100644 --- a/.github/workflows/browserstack.yml +++ b/.github/workflows/browserstack.yml @@ -43,3 +43,4 @@ jobs: env: BROWSER_STACK_ACCESS_KEY: "${{ secrets.BROWSER_STACK_ACCESS_KEY }}" BROWSER_STACK_USERNAME: "${{ secrets.BROWSER_STACK_USERNAME }}" + GITHUB_SHA: "${{ github.sha }}" diff --git a/js/tests/karma.conf.js b/js/tests/karma.conf.js index d0dd8bdd9..4b3c3d9fd 100644 --- a/js/tests/karma.conf.js +++ b/js/tests/karma.conf.js @@ -16,6 +16,7 @@ const { env } = process const browserStack = env.BROWSER === 'true' const debug = env.DEBUG === 'true' const jQueryTest = env.JQUERY === 'true' + const frameworks = [ 'jasmine' ] @@ -106,7 +107,7 @@ if (browserStack) { conf.browserStack = { username: env.BROWSER_STACK_USERNAME, accessKey: env.BROWSER_STACK_ACCESS_KEY, - build: `bootstrap-${new Date().toISOString()}`, + build: `bootstrap-${env.GITHUB_SHA ? env.GITHUB_SHA : ''} ${new Date().toISOString()}`, project: 'Bootstrap', retryLimit: 2 } From e09927c5cf5ae8c4d1c11e0334f3cf03ed3a9573 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Thu, 17 Dec 2020 21:01:56 +0200 Subject: [PATCH 2/2] Update karma.conf.js --- js/tests/karma.conf.js | 1 - 1 file changed, 1 deletion(-) diff --git a/js/tests/karma.conf.js b/js/tests/karma.conf.js index 4b3c3d9fd..3bfa90192 100644 --- a/js/tests/karma.conf.js +++ b/js/tests/karma.conf.js @@ -16,7 +16,6 @@ const { env } = process const browserStack = env.BROWSER === 'true' const debug = env.DEBUG === 'true' const jQueryTest = env.JQUERY === 'true' - const frameworks = [ 'jasmine' ]