rev/hyperX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add line height config (#2858)

Browse source 
Fixes #2858
This commit is contained in:
Brad Dougherty 2018-04-20 18:22:34 -04:00 • committed by CHaBou
parent 57707273c4
commit 75679266c0
6 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/components/term-group.js
View file

@ -71,6 +71,7 @@ class TermGroup_ extends React.PureComponent {
fontSmoothing: this.props.fontSmoothing,
fontWeight: this.props.fontWeight,
fontWeightBold: this.props.fontWeightBold,
lineHeight: this.props.lineHeight,
modifierKeys: this.props.modifierKeys,
padding: this.props.padding,
url: session.url,

7
lib/components/term.js
View file

@ -32,6 +32,7 @@ const getTermOptions = props => {
fontSize: props.fontSize,
fontWeight: props.fontWeight,
fontWeightBold: props.fontWeightBold,
lineHeight: props.lineHeight,
allowTransparency: needTransparency,
experimentalCharAtlas: 'dynamic',
theme: {
@ -263,7 +264,11 @@ export default class Term extends React.PureComponent {
});
}
if (this.props.fontSize !== nextProps.fontSize || this.props.fontFamily !== nextProps.fontFamily) {
if (
this.props.fontSize !== nextProps.fontSize ||
this.props.fontFamily !== nextProps.fontFamily ||
this.props.lineHeight !== nextProps.lineHeight
) {
// invalidate xterm cache about how wide each
// character is
this.term.charMeasure.measure(this.termOptions);

1
lib/components/terms.js
View file

@ -101,6 +101,7 @@ export default class Terms extends React.Component {
uiFontFamily: this.props.uiFontFamily,
fontWeight: this.props.fontWeight,
fontWeightBold: this.props.fontWeightBold,
lineHeight: this.props.lineHeight,
padding: this.props.padding,
bell: this.props.bell,
bellSoundURL: this.props.bellSoundURL,