Split Panes (#693)

* npm: add .npmrc with save-exact=true

* split panes: create initial implementation

This allows users to split their Hyperterm terms into
multiple nested splits, both vertical and horizontal.

Fixes #56

* split panes: suport closing tabs and individual panes

* split panes: ensure new splits are placed at the correct index

New split panes should be placed after the currently active
pane, not at the end like they were previously.

* split panes: add explicit dependency to uuid

* split panes: implement split pane cycling

This adds menu buttons for moving back and forward between
open split panes in the currect terminal tab.
Doesn't add a hotkey yet, needs some bikeshedding.

* split panes: move activeSessionUid to its own object

It made little sense to have so many objects with `activeSessionUid`
set to `null` when it only mattered on the top level.
Now it's an object mapping term-group `uid` to `sessionUid` instead.

* split panes: make sure closing the last split pane exits the app

* split panes: fix a crash after closing specific panes

Sometimes the terminal would crash when a specific
split pane was closed, because the `activeSessions`
mapping wasn't updated correctly.

* split panes: fix a bug that caused initial session sizing to be wrong

* fix all our focus / blur issues in one fell swoop :O (famous last words)

* get rid of react warning

* hterm: make sure not to lose focus when VT listens on clicks

* term: restore onactive callback

* add missing `return` to override (just in case)

* split pane: new split pane implementation

* goodbye react-split-pane

* added term group resizing action and reducer

* terms: supply border color so that we can use it for splits

* term-group: add resizing hook

* term-groups: add resizing constant

* remove split pane css side-effect

* split panes: pass existing hterm instances to Term

* split panes: add keybindings for split pane cycling

* split panes: remove unused action

* split panes: remove unused styling

* split-pane: remove `console.log`

* split-pane: remove `console.log`

* split panes: rebalance sizes on insert/removal

* split panes: pass existing hterm instances to Term

* split panes: add keybindings for split pane cycling

* split panes: remove unused action

* split panes: remove unused styling

* split panes: rebalance sizes on insert/removal

* split panes: set a minimum size for resizing

* split-pane: fix vertical splits

* css :|

* package: bump electron

* split panes: attach onFocus listener to webviews

* 1.4.1 and 1.4.2 are broken. they have the following regression:
- open google.com on the main window
- open a new tab
- come back to previous tab. webview is gone :|

* split panes: handle PTY exits

* split panes: add linux friendly keybindings
This commit is contained in:
Martin Ek 2016-10-03 22:00:50 -04:00 committed by Guillermo Rauch
parent ee172c3164
commit a7595c1a45
29 changed files with 1171 additions and 211 deletions

View file

@ -1,6 +1,7 @@
import rpc from '../rpc';
import getURL from '../utils/url-command';
import {keys} from '../utils/object';
import {findBySession} from '../utils/term-groups';
import {
SESSION_ADD,
SESSION_RESIZE,
@ -9,7 +10,6 @@ import {
SESSION_PTY_DATA,
SESSION_PTY_EXIT,
SESSION_USER_EXIT,
SESSION_USER_EXIT_ACTIVE,
SESSION_SET_ACTIVE,
SESSION_CLEAR_ACTIVE,
SESSION_USER_DATA,
@ -19,13 +19,18 @@ import {
SESSION_SET_PROCESS_TITLE
} from '../constants/sessions';
export function addSession(uid, shell, pid) {
return dispatch => {
export function addSession({uid, shell, pid, cols, rows, splitDirection}) {
return (dispatch, getState) => {
const {sessions} = getState();
dispatch({
type: SESSION_ADD,
uid,
shell,
pid
pid,
cols,
rows,
splitDirection,
activeUid: sessions.activeUid
});
};
}
@ -72,15 +77,16 @@ export function addSessionData(uid, data) {
};
}
export function sessionExit(uid) {
return (dispatch, getState) => {
function createExitAction(type) {
return uid => (dispatch, getState) => {
return dispatch({
type: SESSION_PTY_EXIT,
type,
uid,
effect() {
// we reiterate the same logic as below
// for SESSION_USER_EXIT since the exit
// could happen pty side or optimistic
if (type === SESSION_USER_EXIT) {
rpc.emit('exit', {uid});
}
const sessions = keys(getState().sessions.sessions);
if (!sessions.length) {
window.close();
@ -92,33 +98,8 @@ export function sessionExit(uid) {
// we want to distinguish an exit
// that's UI initiated vs pty initiated
export function userExitSession(uid) {
return (dispatch, getState) => {
return dispatch({
type: SESSION_USER_EXIT,
uid,
effect() {
rpc.emit('exit', {uid});
const sessions = keys(getState().sessions.sessions);
if (!sessions.length) {
window.close();
}
}
});
};
}
export function userExitActiveSession() {
return (dispatch, getState) => {
dispatch({
type: SESSION_USER_EXIT_ACTIVE,
effect() {
const uid = getState().sessions.activeUid;
dispatch(userExitSession(uid));
}
});
};
}
export const userExitSession = createExitAction(SESSION_USER_EXIT);
export const ptyExitSession = createExitAction(SESSION_PTY_EXIT);
export function setActiveSession(uid) {
return (dispatch, getState) => {
@ -163,13 +144,20 @@ export function setSessionXtermTitle(uid, title) {
}
export function resizeSession(uid, cols, rows) {
return {
type: SESSION_RESIZE,
cols,
rows,
effect() {
rpc.emit('resize', {cols, rows});
}
return (dispatch, getState) => {
const {termGroups} = getState();
const group = findBySession(termGroups, uid);
const isStandaloneTerm = !group.parentUid && !group.children.length;
dispatch({
type: SESSION_RESIZE,
uid,
cols,
rows,
isStandaloneTerm,
effect() {
rpc.emit('resize', {uid, cols, rows});
}
});
};
}