Commit graph

18742 commits

Author SHA1 Message Date
patrickhlauke
95ebcedccd Tweak
Stick with the naive `tabs[index].click()` as it works correctly, and trying to trigger just `show()` of a tab instance resulted in weird side effects...

Tighten the outer `makeArrary`/`forEach` loop (assuming when there's an empty array the forEach just bails, so no need to check the length?)
2019-06-19 12:47:13 +01:00
patrickhlauke
cbac96d5b0 Replace for loop with forEach 2019-06-19 11:01:25 +01:00
patrickhlauke
701977bf4e Make note about dropdowns in tabs an actual callout 2019-06-19 10:54:19 +01:00
patrickhlauke
d722edcb29 Remove dropdown-in-tabs related unit tests
Since that logic has now been expunged
2019-06-19 10:48:56 +01:00
patrickhlauke
53e954c834 Initial code tweaks based on comments 2019-06-19 10:22:34 +01:00
Patrick H. Lauke
578444b95e
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-06-18 21:22:35 +01:00
patrickhlauke
78737b239f Add explicit note about aria-orientation, add all missing role="presentation"
`role="presentation"` is needed as otherwise AT (like NVDA) will get confused/won't be able to "count" the total number of tabs properly
2019-06-18 20:32:52 +01:00
patrickhlauke
33df950b27 Remove dropdown-in-tabs related code
- there's no ARIA pattern that would allow dropdowns in tablists; it cannot be expressed accessibly to AT users. it also has serious usability drawbacks. we're already saying in the docs it should not be
used ... this goes a step further and removes the handling for it
2019-06-18 20:19:53 +01:00
patrickhlauke
7c90656c13 WIP add initial keyboard handling and initialisation
- initialisation happens very inelegantly - could do with some advice on how to move this to a function (should it be public, private, static?)
- keyboard handling works, but seems to get confused when switching too quickly between tabs sometimes
- activating tabs currently done via click() - there must be a nicer way to do this...how? fire _activate? which parameters to pass?
2019-06-18 19:59:05 +01:00
XhmikosR
ceffc3a5fd
Update devDependencies. (#28924) 2019-06-18 15:34:43 +03:00
Martijn Cuppens
1efcf7a5dc Typo fix (#28920) 2019-06-18 10:43:15 +03:00
Martijn Cuppens
83fc5a3239
Decrease number of order utilities (#28874) 2019-06-18 07:02:14 +02:00
patrickhlauke
f4d85517b9 Add initial tabindex handling for tabs
set `tabindex` as well as `aria-selected` on tabs
2019-06-17 23:45:07 +01:00
Ashfahan Khan
c5b1919dea Add Error checking to prevent invalid breakpoint (#28889)
* Add Error checking to prevent invalid breakpoint

Error checking to prevent invalid breakpoint name

* check type rather than value

* Revert "check type rather than value"

This reverts commit 04ab1e652f9c9c1c7725b7328b12f548a2c6d142.

* use of not rather than null
2019-06-17 08:00:36 +02:00
david-lallement
0829decce0 tooltip dispose:removing only own event handler (#28896) 2019-06-13 10:42:54 +02:00
Martijn Cuppens
2ac2a5a91e Removal of one of the most iconic components of Bootstrap: the jumbotron (#28876) 2019-06-07 14:44:25 +03:00
XhmikosR
cafbbdc3b6 Update site/content/docs/4.3/examples/sticky-footer-navbar/index.html
Co-Authored-By: Shohei Yoshida <fellows3@gmail.com>
2019-06-06 19:15:18 +03:00
XhmikosR
1835004b96 Update site/content/docs/4.3/examples/sticky-footer-navbar/index.html
Co-Authored-By: Shohei Yoshida <fellows3@gmail.com>
2019-06-06 19:15:18 +03:00
XhmikosR
8c61254919 Examples: make use of core utils in more places. 2019-06-06 19:15:18 +03:00
Shohei Yoshida
543ff4e3e5 Clean component examples CSS (#28872)
* Remove unused classes/styles and use utilities instead of specific styles
* Use `getElementById` instead of `querySelector`
2019-06-06 09:04:48 +03:00
Shohei Yoshida
1c510ddaec Make generating form row styles dependent on $enable-grid-classes (#28870) 2019-06-05 18:15:27 +03:00
Shohei Yoshida
8437be2f33 Rename the text helper page (#28869) 2019-06-04 20:46:52 +02:00
Shohei Yoshida
3283fe1b52
Rename .text-monospace to .font-monospace (#28867) 2019-06-05 00:51:36 +09:00
Patrick H. Lauke
87030c98ac Docs: add accessibility/keyboard callout to popovers, tweak tooltips callout (#28851)
- Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal)
- Tweak the tooltips callout for consistency
2019-06-04 10:36:57 +03:00
Shohei Yoshida
d6e0552efe Workaround for the image size bug in IE (#28855) 2019-06-04 10:25:19 +03:00
XhmikosR
cb4cdbf2bb
Add initial FUNDING.yml (#28824) 2019-06-04 10:03:09 +03:00
XhmikosR
8f97e2dc52
Update devDependencies. (#28798)
Notably:

* bundlesize 0.15.3 → ^0.17.2
* eslint-plugin-unicorn ^8.0.2 → ^9.0.0
* terser ^3.17.0 → ^4.0.0
2019-06-03 14:26:52 +03:00
XhmikosR
8a79cf894d event-handler.js: use a plain for loop. (#28853) 2019-06-03 13:08:17 +02:00
Christian Oliff
319de5b309 HTTPS link to codeguide.co (#28860) 2019-06-03 10:36:49 +03:00
Ashfahan Khan
41fcd13d3e Utility API improvement: use $key/$value instead of nth (#28828)
Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
2019-05-30 17:22:06 +02:00
XhmikosR
fd21354de2
Use npm-run-all in the netlify script. (#28846) 2019-05-30 10:52:50 +03:00
Martijn Cuppens
14cb65f702
Remove redundant properties from .embed-responsive (#28062) 2019-05-29 19:42:32 +02:00
Shane Parsons
4c70e96b97 Modify .card-header-tabs .nav-link.active colors (#28833)
Co-Authored-By: Mark Otto <otto@github.com>
2019-05-29 18:38:36 +02:00
Jay Pinho
91d07fb26c Make example description more accurate (#28842) 2019-05-29 18:17:40 +03:00
Shohei Yoshida
072622d959 Clean input group flex basis (#28785) 2019-05-28 22:28:39 +03:00
Shohei Yoshida
b28322469e Calc modal header/footer border radius according to the border width (#28775) 2019-05-28 14:21:45 +02:00
Aditya Shankar
111024695a Correct grammar in modal.scss (#28829) 2019-05-27 08:19:50 +02:00
Sezer Esen
de1a6e3201 Fix background position (#28814) 2019-05-26 11:13:55 +02:00
Ashfahan Khan
c215dc83f0 Fix Typo Mistake in SCSS comment (#28821) 2019-05-24 22:09:09 +01:00
XhmikosR
1ce7960c6c
vnu.jar: Update ignores. (#28817)
Pass the `--no-langdetect` flag instead of ignoring the warning manually.
2019-05-24 13:19:13 +03:00
Martijn Cuppens
769c8d8246
Helpers & utilities split (#28445) 2019-05-23 11:56:03 +02:00
Martijn Cuppens
a4a04cd9ec
.sr-only & .sr-only-focusable tweaks (#28720)
* Prevent .sr-only-focusable overriding properties when being focused

* Typo
2019-05-20 10:03:51 +02:00
Shohei Yoshida
1a41b0ffa6 Fix z-index according to our z-index rule (#28784)
https://getbootstrap.com/docs/4.3/extend/approach/#z-index-scales
2019-05-18 16:30:57 +02:00
Christian Oliff
2d6e086342 Update Yarn package link to link to the Bootstrap package (#28781)
I think it makes more sense to link to the Bootstrap package on Yarn here (like the package link for NPM above)
2019-05-16 21:47:26 +03:00
XhmikosR
552e11a1ab linkinator: add silent flag.
This should reduce its output.
2019-05-16 16:01:07 +03:00
XhmikosR
6269d05670 Update devDependencies. 2019-05-16 16:01:07 +03:00
Johann-S
02f80c1616 remove util references from our docs 2019-05-16 14:44:11 +02:00
Johann-S
803088c526 remove jquery references from tooltip docs 2019-05-16 14:44:11 +02:00
Johann-S
976e825d26 remove jquery references in browsers-devices docs 2019-05-16 14:44:11 +02:00
Johann-S
759fe25567 remove jquery references in toast docs 2019-05-16 14:44:11 +02:00