Commit graph

18789 commits

Author SHA1 Message Date
Brian Juul Andersen
4fdae4b1a8 Update collapse.md (#29025)
Corrected minor spelling error.
2019-07-13 22:20:44 +01:00
Mark Otto
a13fba81f2 dist v5 2019-07-13 22:20:44 +01:00
Mark Otto
79d538703c v5: Forms update (#28450)
* Initial spike of consolidated form checks

* Stub out forms rearrangement

- Prepping to drop non-custom file and range inputs
- Prepping to merge custom and native checks and radios (with switches)
- Prepping to merge custom select with form select
- Moving docs arround so forms has it's own area given volume of CSS

* Move input group Sass file to forms subdir

* Start to split and move the docs around

* Simpler imports

* Copyediting

* delete overview file

* Remove commented out code

* remove the custom-forms import

* rewrite flex-check as form-check, replace all custom properties

* Remove old forms doc

* stub out new subpage link section

* update migration guide

* Update nav, forms overview in page nav, and descriptions

* fix check bg position

* fix margin-top calculation

* rename .custom-select to .form-select

* Update validation styles for new checks

* add some vertical margin, fix inline checks

* fix docs examples

* better way to do this contents stuff, redo the toc while i'm at it

* page restyle for docs while here

* un-callout that, edit text

* redo padding on toc

* fix toc

* start to cleanup checks docs

* Rewrite Markdown tables into HTML

* Redesign tables, redo their docs

* Replace Open Iconic icons with custom Bootstrap icons

* Redesign the docs navbar, add a subheader, redo the sidebar

* Redesign docs homepage a bit

* Simplify table style overrides for docs tables

* Simplify docs typography for page titles and reading line length

* Stub out icons page

* Part of sidebar update, remove migration from nav.yml

* Move toc CSS to separate partial

* Change appearance of overview page

* fix sidebar arrow direction

* Add footer to docs layout

* Update descriptions

* Drop the .form-group class for margin utilities

* Remove lingering form-group-margin-bottom var

* improve footer spacing

* add headings to range page

* uncomment form range css

* Rename .custom-range to .form-range

* Drop unused docs var

* Uncomment the comment

* Remove unused variable

* Fix radio image sizing

* Reboot update: reset horizontal ul and ol padding

* de-dupe IDs

* tweak toc styles

* nvm, fix dropdown versions stuff

* remove sidebar nav toggle for now

* broken html

* fix more broken html, move css

* scss linting

* comment out broken helper docs

* scope styles

* scope styles

* Fixes #25540 and fixes #26407 for v5 only

* Update sidebar once more

* Match new sidenav order

* fix syntax error

* Rename custom-file to form-file, update paths, update migration docs for previous changes in #28696

* rename back

* fix size and alignment

* rename that back too
2019-07-13 22:20:44 +01:00
Shohei Yoshida
cc5353da66 Drop support for .form-control-plaintext inside .input-group (#28972)
* Revert "Fix readonly-plain-text with button addon (#25871)"

This reverts commit ff40e00323.

* Add migration comment
2019-07-13 22:20:43 +01:00
Martijn Cuppens
bfe5438af2 Remove attribute selectors (#28988) 2019-07-13 22:20:43 +01:00
Johann-S
e81f20cb0e separate file for our polyfills to have lighter plugins 2019-07-13 22:20:43 +01:00
XhmikosR
349eeeb532 Fix typo. (#29008) 2019-07-13 22:20:43 +01:00
Mark Otto
76f87e2bef Fixes #28994 2019-07-13 22:20:42 +01:00
patrickhlauke
a38a3bd904 Fix visual unit test
fix the borked examples of dynamic tab panels, and remove the now unsupported tabs with dropdowns
2019-07-13 22:20:42 +01:00
patrickhlauke
430a1204aa Add extensive keyboard handling unit tests
very verbose, but fully tests that cursor keys are handled correctly and have the desired final result (though stops short of checking the actual tab panels themselves)
2019-07-13 22:02:04 +01:00
patrickhlauke
fabe1f0e24 Remove redundant sanity checks
unnecessary, as these checks should never fail (since the handler would not be called if there weren't any tabs, and the `index > 0` clause in the preceding `if` ensures that `index` will never be negative
2019-07-13 21:52:21 +01:00
patrickhlauke
1687b77a48 Fix one of the existing unit tests
the markup fragment does not reflect proper code structure (surprising that it still worked...)
2019-07-13 16:52:28 +01:00
patrickhlauke
eb299c90e5 Unit test for tablist initialization
- check that `tabindex` and `aria-selected` are properly set up with only one `aria-selected="true"` and `tabindex="0"`
- check that as fallback the first tab control is set to `aria-selected="true"`
2019-07-13 16:48:26 +01:00
patrickhlauke
65b32a0107 Merge branch 'patrickhlauke-tabs-kbd-automatic-activation' of https://github.com/twbs/bootstrap into patrickhlauke-tabs-kbd-automatic-activation 2019-07-13 10:56:38 +01:00
Patrick H. Lauke
eace005286
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-07-09 17:03:13 +01:00
XhmikosR
c7a847b6a1
Move bundlesize config to a separate file. (#29002) 2019-07-09 17:18:14 +03:00
Patrick H. Lauke
10b293f23e
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-07-09 00:12:32 +01:00
Patrick H. Lauke
53a3d449fd Add prefers-reduced-motion callout to toast documentation (#28993)
x-ref #28987
2019-07-08 21:05:53 +03:00
Johann-S
ea0e99dfc5 add transitioning state to avoid displaying two tabs in the same time 2019-07-08 14:45:04 +02:00
patrickhlauke
d5616fe0ce Add missing aria-orientation to list group tablists
For correct keyboard handling (cursor up/down) when interacting with these
2019-07-08 14:20:19 +02:00
patrickhlauke
3c8170044a Tweak
Stick with the naive `tabs[index].click()` as it works correctly, and trying to trigger just `show()` of a tab instance resulted in weird side effects...

Tighten the outer `makeArrary`/`forEach` loop (assuming when there's an empty array the forEach just bails, so no need to check the length?)
2019-07-08 14:20:19 +02:00
patrickhlauke
7c79b8a80f Replace for loop with forEach 2019-07-08 14:20:19 +02:00
patrickhlauke
66d0d7b05e Make note about dropdowns in tabs an actual callout 2019-07-08 14:20:19 +02:00
patrickhlauke
35179a4aee Remove dropdown-in-tabs related unit tests
Since that logic has now been expunged
2019-07-08 14:20:19 +02:00
patrickhlauke
a8cf124b82 Initial code tweaks based on comments 2019-07-08 14:20:19 +02:00
patrickhlauke
31dd87c600 Add explicit note about aria-orientation, add all missing role="presentation"
`role="presentation"` is needed as otherwise AT (like NVDA) will get confused/won't be able to "count" the total number of tabs properly
2019-07-08 14:20:19 +02:00
patrickhlauke
a1e7738632 Remove dropdown-in-tabs related code
- there's no ARIA pattern that would allow dropdowns in tablists; it cannot be expressed accessibly to AT users. it also has serious usability drawbacks. we're already saying in the docs it should not be
used ... this goes a step further and removes the handling for it
2019-07-08 14:20:19 +02:00
patrickhlauke
da9f93da1c WIP add initial keyboard handling and initialisation
- initialisation happens very inelegantly - could do with some advice on how to move this to a function (should it be public, private, static?)
- keyboard handling works, but seems to get confused when switching too quickly between tabs sometimes
- activating tabs currently done via click() - there must be a nicer way to do this...how? fire _activate? which parameters to pass?
2019-07-08 14:20:19 +02:00
patrickhlauke
2e5a010901 Add initial tabindex handling for tabs
set `tabindex` as well as `aria-selected` on tabs
2019-07-08 14:20:18 +02:00
Patrick H. Lauke
007c75837d
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-07-06 11:46:30 +01:00
Bardi Harborow
08bddb8743 Add ARIA search landmark to documentation. (#28983) 2019-07-02 21:17:42 +03:00
Martijn Cuppens
f5f09d8b0b
Remove redundant border radius on pagination (#28980)
Pagination used to have box shadow back in the days which required this property, but nowadays it's redundant. (see https://github.com/twbs/bootstrap/blame/0cd186183c5e18f0517d6037d53f29c56adbac72/less/pagination.less#L17)
2019-07-02 08:08:12 +02:00
Martijn Cuppens
4b3d2635f3
Remove redundant radius properties (#28956) 2019-06-26 15:11:37 +02:00
Martijn Cuppens
65f21bbef1 Fix pre color (#28966) 2019-06-26 13:18:59 +03:00
Martijn Cuppens
27824ec586 Stretched link updates (#28958)
- Remove IE10 background hack
- Ability to change the pseudo element
- Ability to change the z-index
- Remove pointer events, just inherit this
2019-06-26 07:54:51 +03:00
Patrick H. Lauke
8be4c1364f
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-06-25 15:21:49 +01:00
Patrick H. Lauke
f2c63ac729 Port new unit test for dropdown from v4 (#28913)
Add unit test from #28912 to v5
2019-06-25 14:57:41 +03:00
Patrick H. Lauke
3b64256ac5
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-06-25 09:47:11 +01:00
Sergey Kovalenko
ad62301a5b Remove negative margins for group list items (#28940)
To fix RGBA borders overlapping issue.
2019-06-25 09:23:36 +03:00
Patrick H. Lauke
ef0c5c04e3
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-06-24 21:14:06 +01:00
XhmikosR
2fb6ccf951 Minor wording changes. 2019-06-24 09:15:52 +03:00
Jonathan Hawkins
39fc46fb71 Combine duplicate documentation examples into one to fix the confusing text.
fixes issue #28892
2019-06-24 09:15:52 +03:00
Martijn Cuppens
ac6eefd227
Change invalid icon from cross to exclamation mark (#28944)
The cross icon was confusing since some browsers use it as a reset button.
2019-06-22 16:21:11 +02:00
Robin D'Arcy
cbabd8ff0d Docs – update extend/approach.md (#28941) 2019-06-22 16:21:20 +03:00
patrickhlauke
8de6558408 Add missing aria-orientation to list group tablists
For correct keyboard handling (cursor up/down) when interacting with these
2019-06-19 14:16:33 +01:00
Patrick H. Lauke
d91293d966
Merge branch 'master' into patrickhlauke-tabs-kbd-automatic-activation 2019-06-19 12:58:23 +01:00
patrickhlauke
95ebcedccd Tweak
Stick with the naive `tabs[index].click()` as it works correctly, and trying to trigger just `show()` of a tab instance resulted in weird side effects...

Tighten the outer `makeArrary`/`forEach` loop (assuming when there's an empty array the forEach just bails, so no need to check the length?)
2019-06-19 12:47:13 +01:00
patrickhlauke
cbac96d5b0 Replace for loop with forEach 2019-06-19 11:01:25 +01:00
patrickhlauke
701977bf4e Make note about dropdowns in tabs an actual callout 2019-06-19 10:54:19 +01:00
patrickhlauke
d722edcb29 Remove dropdown-in-tabs related unit tests
Since that logic has now been expunged
2019-06-19 10:48:56 +01:00